mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat (GroupTheory/Congruence): add simp lemmas for comap equivalences

Open hannahfechtner opened this issue 1 year ago • 2 comments

add a few lemmas, mostly about when the underlying types are equal, so too must be the quotient

Open in Gitpod

hannahfechtner avatar Sep 27 '24 23:09 hannahfechtner

PR summary b0c18d3439

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comapQuotientEquivOfSurj + comapQuotientEquivOfSurj_mk + comapQuotientEquivOfSurj_symm_mk + comapQuotientEquivOfSurj_symm_mk' + comap_conGen_equiv + comap_conGen_of_bijective + congr_mk + le_comap_conGen

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

github-actions[bot] avatar Sep 27 '24 23:09 github-actions[bot]

Something's a bit messed up with this PR (the diff is 90k lines). Maybe merge master? Or if that doesn't work, ask on Zulip.

tb65536 avatar Oct 24 '24 20:10 tb65536

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

github-actions[bot] avatar Nov 03 '24 18:11 github-actions[bot]

bors r-

Vierkantor avatar Nov 04 '24 09:11 Vierkantor

Canceled.

mathlib-bors[bot] avatar Nov 04 '24 09:11 mathlib-bors[bot]

Discussed with @jcommelin and approved so:

bors d+

Vierkantor avatar Nov 04 '24 12:11 Vierkantor

:v: hannahfechtner can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Nov 04 '24 12:11 mathlib-bors[bot]

bors r+

hannahfechtner avatar Nov 04 '24 12:11 hannahfechtner

Oh, it looks like my change wasn't yet applied. So we need to wait before merging until it is done. Is it okay if I push to your branch?

bors r-

Vierkantor avatar Nov 04 '24 12:11 Vierkantor

Canceled.

mathlib-bors[bot] avatar Nov 04 '24 12:11 mathlib-bors[bot]

@Vierkantor of course! thank you

hannahfechtner avatar Nov 04 '24 16:11 hannahfechtner

Pushed and built so Let's Get This Merged!

bors r+

Vierkantor avatar Nov 04 '24 16:11 Vierkantor

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Nov 04 '24 17:11 mathlib-bors[bot]