mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: rewrite set_option style linter in lean

Open grunweg opened this issue 1 year ago • 2 comments

Unlike the Python version, this script also supports set_option tactics and terms, and we add a couple of tests.


Mentored by @digama0; thanks for all your help. Written at the HIM school on formalization of mathematics.

Open in Gitpod

grunweg avatar May 15 '24 13:05 grunweg

Actually, this PR is blocked on #11807 (and adapting it accordingly).

grunweg avatar May 22 '24 12:05 grunweg

~~The CI failure is interesting: I have no idea where this is coming from. Help on this detail is welcome.~~ After rebasing, CI passes. I guess it was something intermittent.

grunweg avatar May 22 '24 15:05 grunweg

I could see a case for generalizing this: the list of disallowed options should be customizable/extensible by downstream projects. But, future work. Thanks!

bors merge

robertylewis avatar Jun 19 '24 08:06 robertylewis

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jun 19 '24 09:06 mathlib-bors[bot]

Thanks for the review! I agree that making this list configurable could be useful - if somebody sees a specific use, I'm happy to look at PRs extending this!

grunweg avatar Jun 19 '24 10:06 grunweg