mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: `linting_rules` and deprecated syntax

Open thorimur opened this issue 1 year ago • 11 comments


Experimental. WIP. Might not be performance-viable.

  • [ ] depends on: #11519

Open in Gitpod

thorimur avatar Mar 19 '24 23:03 thorimur

!bench

thorimur avatar Mar 19 '24 23:03 thorimur

This PR/issue depends on:

Here are the benchmark results for commit 93a911c7170a76ebf34da4e62b5225b33632ac72. The entire run failed. Found no significant differences.

leanprover-bot avatar Mar 20 '24 00:03 leanprover-bot

!bench

thorimur avatar Mar 20 '24 00:03 thorimur

Here are the benchmark results for commit 3ce1b457ea3d7704d29a8ce57c988195d5491ae5. There were significant changes against commit 8ff9aa61aa54b5a0eaede0e1db6e9e167cb05bd5:

  Benchmark                    Metric           Change
  ====================================================
- build                        interpretation    19.9%
- ~Mathlib.Data.Finset.Basic   instructions      13.1%
- ~Mathlib.Data.List.Basic     instructions      15.5%

leanprover-bot avatar Mar 20 '24 01:03 leanprover-bot

!bench

thorimur avatar Mar 20 '24 01:03 thorimur

Here are the benchmark results for commit b14b7a4a04f6915adf5499eef6d17eee5589c816. There were significant changes against commit 8ff9aa61aa54b5a0eaede0e1db6e9e167cb05bd5:

  Benchmark   Metric           Change
  ===================================
- build       interpretation    12.9%
- build       parsing            5.0%

leanprover-bot avatar Mar 20 '24 01:03 leanprover-bot

!bench

thorimur avatar Mar 20 '24 03:03 thorimur

Here are the benchmark results for commit e3c4bb76b361ff33f834b53faa50dab527ec3abb. There were significant changes against commit 8ff9aa61aa54b5a0eaede0e1db6e9e167cb05bd5:

  Benchmark   Metric           Change
  ===================================
- build       interpretation    11.8%

leanprover-bot avatar Mar 20 '24 03:03 leanprover-bot

!bench

thorimur avatar Mar 20 '24 20:03 thorimur

Here are the benchmark results for commit f3707c8ad26069c7207557153a1071bc949f3f3b. There were no significant changes against commit 8ff9aa61aa54b5a0eaede0e1db6e9e167cb05bd5.

leanprover-bot avatar Mar 20 '24 21:03 leanprover-bot