react-tech-tree icon indicating copy to clipboard operation
react-tech-tree copied to clipboard

Tree Element Has Wrong Props Type

Open amrabdelshafi97 opened this issue 4 years ago • 2 comments

It should be changed from NodeProps to TreeProps

amrabdelshafi97 avatar Feb 08 '21 11:02 amrabdelshafi97

yup you are right

 declare function Node<T extends NodeProps>(props: T): JSX.Element;
-  declare function Tree<T extends NodeProps>(props: T): JSX.Element;
+  declare function Tree<T extends TreeProps>(props: T): JSX.Element;

in the distributed index.d.ts, right? tbh, now is a good time as any to update that file. I should've written it in typescript in the first place 😅

ldd avatar Mar 14 '21 06:03 ldd

Really wish this actually worked. Still isn't fixed.

Pangamma avatar Jun 06 '23 03:06 Pangamma