druntime icon indicating copy to clipboard operation
druntime copied to clipboard

[ltsmaster] Add setjmp/ucontext definitions for FreeBSD/aarch64

Open valpackett opened this issue 6 years ago • 4 comments

This is https://github.com/dlang/druntime/pull/2269 which is still not cherry-picked into ltsmaster

valpackett avatar Jun 15 '19 21:06 valpackett

Is this really needed? [ltsmaster just needs to be able to compile the current/a recent version of LDC]

kinke avatar Jun 20 '19 08:06 kinke

Yes, it can't compile its own runtime with these types missing.

cd /usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster && /usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/bin/ldc2 --output-o -c -I/usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/runtime/druntime/src -I/usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/runtime/druntime/src/gc /usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/runtime/druntime/src/core/sys/posix/setjmp.d -of=/usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/runtime/src/core/sys/posix/setjmp-debug.o -w -g -link-debuglib -disable-invariants
/usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/runtime/druntime/src/core/sys/posix/setjmp.d(168): Error: undefined identifier '_jmp_buf', did you mean alias 'jmp_buf'?
/usr/ports/lang/ldc/work/ldc-1.15.0/ltsmaster/runtime/druntime/src/core/sys/posix/setjmp.d(255): Error: undefined identifier '_sigjmp_buf', did you mean alias 'sigjmp_buf'?

valpackett avatar Jun 20 '19 10:06 valpackett

Alright, thx. Is this the last (edit: ltsmaster) blocker for FreeBSD/aarch64?

kinke avatar Jun 20 '19 15:06 kinke

well, this and

--- ltsmaster/runtime/phobos/std/internal/math/gammafunction.d.orig     2019-04-20 23:21:36 UTC
+++ ltsmaster/runtime/phobos/std/internal/math/gammafunction.d
@@ -1654,7 +1654,6 @@ real logmdigammaInverse(real y)
 {
     import std.numeric: findRoot;
     enum maxY = logmdigamma(real.min_normal);
-    static assert(maxY > 0 && maxY <= real.max);

     if (y >= maxY)
     {

valpackett avatar Jun 20 '19 16:06 valpackett