jQuery-Selectric icon indicating copy to clipboard operation
jQuery-Selectric copied to clipboard

Fix multiple selected detection with optgroup

Open 2j0ye opened this issue 8 years ago • 1 comments

Based on the work of @ruoqianfengshao This is a basic change that fixes the issue #217
Fork based on master / v1.13.0

  • I didn't upgrade any npm dependencies
  • I just changed the line 406 of the file src/jquery.selectric.js as shown below
src/jquery.selectric.js
@@ -403,7 +403,7 @@
-  selectedIndex.push($(this).index());
+  selectedIndex.push($(_this.$element.find('option')).index(this));
  • And re-ran the build via gulp

Up to you, this fork seems to be OK. Julien

2j0ye avatar Feb 02 '18 15:02 2j0ye

Codecov Report

Merging #223 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #223   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         391    391           
=====================================
  Hits          391    391
Impacted Files Coverage Δ
src/jquery.selectric.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b92c26...83581cd. Read the comment docs.

codecov-io avatar Feb 02 '18 15:02 codecov-io