lbry-android icon indicating copy to clipboard operation
lbry-android copied to clipboard

Crash when Reposting with a 0 LBC Stake and no Channel Selected

Open cahlenlee opened this issue 5 years ago • 5 comments

DESCRIPTION:

Attempting to Repost a video with a 0 LBC Stake and no Channel selected results in a Crash.


REPRO STEPS:

  1. Install and Launch LBRY 0.15.6 on Android 9
  2. Navigate to 'Menu > All Content'
  3. Select any video
  4. Select 'Repost'
  5. Select 'Show Advanced'
  6. Change 'Deposit' to 0.000
  7. Select 'Repost'

Results: Crash

Expected: Error appears


ENVIRONMENT:

  • Galaxy S5
  • Android 9
  • LBRY 0.15.6

MEDIA:

etc-1500


INTERNAL USE:


DEFINITION OF DONE:

  • [ ] Tested against acceptance criteria
  • [ ] Tested against the assumptions of the user story
  • [ ] The project builds without errors
  • [ ] Unit tests are written and passing
  • [ ] Tests on devices/browsers listed in the issue have passed
  • [ ] QA performed & issues resolved
  • [ ] Refactoring completed
  • [ ] Any configuration or build changes documented
  • [ ] Documentation updated
  • [ ] Peer Code Review performed

LBRY ADDRESS: bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b [email protected]

cahlenlee avatar May 26 '20 18:05 cahlenlee

If reposting to a channel is a requirement, then the Repost button shouldn't be available. Then, I suggest validating the stake and showing a toast if the amount is not high enough.

kekkyojin avatar Jun 15 '20 14:06 kekkyojin

@kekkyojin Doesn't look like it image Maybe just allow anonymous reposts then.

clay53 avatar Jul 13 '20 17:07 clay53

This was fixed on commit 40c36df4 and 4a3db5ae.

Trying to reproduce this bug on latest available source code 0.15.14 ends with a error message toasted on the bottom part of the device screen. When user is already signed on, the reposting channel is pre-selected and cannot be changed, so reported problem cannot be reproduced, neither.

Could you update LBRY Android to latest release and check this, @cahlenlee? Thank you.

kekkyojin avatar Jul 13 '20 22:07 kekkyojin

This no longer reproduces in 0.15.14. Appropriate error messages appear if value is set to 0, or if user tries to submit a non-zero value with no channel selected.

cahlenlee avatar Jul 14 '20 00:07 cahlenlee

No Longer Occurs on 0.16.11. Recommend Closing.

cahlenlee avatar Dec 18 '20 21:12 cahlenlee