sistent icon indicating copy to clipboard operation
sistent copied to clipboard

[UI]: add a version tag to CatalogCard component

Open SAHU-01 opened this issue 1 year ago • 17 comments

Notes for Reviewers

This PR fixes #688

Signed commits

  • [x] Yes, I signed my commits.

SAHU-01 avatar Jul 24 '24 13:07 SAHU-01

@dottharun

sudhanshutech avatar Aug 02 '24 11:08 sudhanshutech

@sudhanshutech based on the Wednesday call feedback that I received, I need to add the flipable thingy and also centralize the catalog card and add on flip all the details that were available on meshery cloud. I'll be done with this over the weekend and will make sure to notify you.

SAHU-01 avatar Aug 02 '24 12:08 SAHU-01

oh its good. I was tagging @dottharun to confirm does he has any things to confirm here?

sudhanshutech avatar Aug 02 '24 13:08 sudhanshutech

@SAHU-01 Does this support dark mode, and can you provide screenshots if you can?

dottharun avatar Aug 02 '24 13:08 dottharun

@dottharun the tag color doesn't change with dark or light mode switch as of now if you want me to enable that, do let me know image image

SAHU-01 avatar Aug 02 '24 13:08 SAHU-01

@SAHU-01 Yes, please use the same shades as the footer.

dottharun avatar Aug 04 '24 23:08 dottharun

@dottharun I did add the version background based on the color palette used for metrics container and it looks something like this: for dark theme: image for light theme: image

SAHU-01 avatar Aug 05 '24 05:08 SAHU-01

@sudhanshutech, I have a couple of questions here:

  1. should I move all styled components like this to src>custom>CatalogCard>style.css:
const BackFaceContent = styled(Box)(({ theme }) => ({
  position: 'absolute',
  background: `linear-gradient(to bottom right, black 40%, ${theme.palette.background.brand?.default})`,
  width: '100%',
  top: 0,
  left: 0,
  display: 'flex',
  flexDirection: 'column',
  alignItems: 'left',
  padding: '16px',
  boxShadow: `2px 2px 3px 0px black`,
  borderRadius: '1rem'
}));
  1. As discussed earlier for lining issues I've added a new interface do let em know if that requires changes.
  2. @dottharun had suggested adding version background based on the color palette used for metrics container please take a look at it and let me know if that suits or we could opt for a different color palette
  3. The linear gradient is not similar to the one on Catalog Page I was unable to find a figma for the flip catalog card, do let me know if that needs to be changed, I would need the exact hex codes though.

SAHU-01 avatar Aug 05 '24 06:08 SAHU-01

Please find the demo screen here:

https://github.com/user-attachments/assets/c8849249-b816-4044-b9ea-2906b296187f

SAHU-01 avatar Aug 05 '24 06:08 SAHU-01

@SAHU-01 yes the styles should be in separate style folder

sudhanshutech avatar Aug 05 '24 07:08 sudhanshutech

@SAHU-01 If we are using the flip card and showing the version only on the backside, just use the same shades as in https://meshery.layer5.io/.

dottharun avatar Aug 05 '24 13:08 dottharun

any more help needed @SAHU-01 ?

sudhanshutech avatar Aug 06 '24 13:08 sudhanshutech

@sudhanshutech yes, the figma design? Does the gradient and padding look good to you in the recording? If yes I'll push the style file and tag theme changes now?

SAHU-01 avatar Aug 06 '24 13:08 SAHU-01

the color of metrics in from of card could be shade of white for dark mode. See which looks good from using the token.

sudhanshutech avatar Aug 06 '24 19:08 sudhanshutech

@SAHU-01 have gone through the card here in cloud,: https://meshery.layer5.io/catalog?

sudhanshutech avatar Aug 06 '24 20:08 sudhanshutech

@dottharun @vishalvivekm @captain-Akshay do we have figma design for this card?

sudhanshutech avatar Aug 06 '24 20:08 sudhanshutech

@dottharun, I've removed the flip logic from this PR and I've added the versionTag and the versionTagPosition props with proper styling as per your suggestion. @sudhanshutech I'll be sending the other PR with centralized sistent logic soon. Currently this is how it looks:

https://github.com/user-attachments/assets/3af4314b-855a-4d43-8b98-34d6e4750eeb

SAHU-01 avatar Aug 12 '24 11:08 SAHU-01