getnighthawk icon indicating copy to clipboard operation
getnighthawk copied to clipboard
verified publisher icon layer5io

Update main.go

Open shivangshandilya opened this issue 2 years ago • 4 comments

Description

This PR fixes #288

Notes for Reviewers

log.Fatal() has been replaced with log.Error()

Signed commits

  • [x] Yes, I signed my commits.

shivangshandilya avatar Apr 11 '23 09:04 shivangshandilya

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

welcome[bot] avatar Apr 11 '23 09:04 welcome[bot]

Thanks, @ShivangShandilya, could you help with the Go lint issue too here?

Chadha93 avatar Jul 18 '23 06:07 Chadha93

Thanks, @ShivangShandilya, could you help with the Go lint issue too here?

Can you elaborate on this??

shivangshandilya avatar Jul 20 '23 02:07 shivangshandilya

I personally would favor usage of log.Fatal instead of consequent log.Error and return statements. It is because return statementstend to return while log.Fatal tends to stop the program. Imagine threading situations, where Fatal would be preferred over return's. I'd say this PR will rather degrade the system.

Sweetdevil144 avatar Jun 16 '24 07:06 Sweetdevil144