getnighthawk icon indicating copy to clipboard operation
getnighthawk copied to clipboard

Changes in main.go

Open shivangshandilya opened this issue 2 years ago • 3 comments

Current Behavior

Currently in the go code of nighthawks main.go we are using log.Fatal() but log.Fatal() terminates the program completely after encountering an error

Desired Behavior

Here in the go program I think we can handle errors more efficiently using log.Error() instead of log.Fatal(). As log.Fatal() terminates the program completely but log.Error() logs the error msg but allows the program to continue execution. This way, even if one error occurs, the program can continue to process the rest of the results, and the error messages will help in troubleshooting.


Resources image

Alternatives / Additional Context


Contributor Resources

shivangshandilya avatar Apr 11 '23 09:04 shivangshandilya

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

welcome[bot] avatar Apr 11 '23 09:04 welcome[bot]

HI @ShivangShandilya are you working on this issue?

AryanSharma9917 avatar Jun 19 '23 06:06 AryanSharma9917

hey @AryanSharma9917 as you can see I have already opened up a PR which might close this issue when merged

shivangshandilya avatar Jun 19 '23 20:06 shivangshandilya