docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix 'YOU ARE HERE' indicator in Kanvas, cloud documentation

Open ShivprasadRoul opened this issue 10 months ago • 7 comments

[Docs] Fix "YOU ARE HERE" indicator in Kanvas documentation

Description

This PR fixes the "YOU ARE HERE" indicator in the Kanvas documentation page. The indicator was previously not rendering correctly and showing raw HTML code. Now it's properly implemented with the same styling as in the Cloud documentation, with capitalized "YOU ARE HERE" text as requested.

During the discussion about this issue, I was initially asked to replace the square with a pin icon, but after trying this approach, I found that it looked odd and negatively affected the layout. Instead, I implemented a solution that highlights the entire section with the same styling used in the Cloud documentation, which provides better visual indication and consistency across the docs.

As per Lee's feedback, I've made sure to capitalize the "YOU ARE HERE" text to maintain consistency with the Cloud documentation.

Before: image image

After: image image

Notes for Reviewers

This PR fixes #455

Signed commits

  • [x] Yes, I signed my commits.

ShivprasadRoul avatar Mar 16 '25 08:03 ShivprasadRoul

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
Latest commit ae1c64e6fc37a3cc9cbbe9b2a0cea62e97d1775d
Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67ea6fcf38e2440008d4bb46
Deploy Preview https://deploy-preview-458--bejewelled-pegasus-b0ce81.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 16 '25 08:03 netlify[bot]

@ShivprasadRoul Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

vishalvivekm avatar Mar 17 '25 10:03 vishalvivekm

Thanks for working on this, @ShivprasadRoul!

leecalcote avatar Mar 21 '25 22:03 leecalcote

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Mar 21 '25 22:03 github-actions[bot]

one-time instructions here - https://github.com/layer5io/docs/pull/458/checks?check_run_id=38840866547 - for amending commits, @ShivprasadRoul

leecalcote avatar Mar 21 '25 22:03 leecalcote

@ShivprasadRoul incorporate the suggestion, if you would, please :)

vishalvivekm avatar Mar 23 '25 19:03 vishalvivekm

@ShivprasadRoul ?

vishalvivekm avatar Mar 31 '25 10:03 vishalvivekm

There is a new implementation of this signal. Please review, @ShivprasadRoul

miacycle avatar May 15 '25 20:05 miacycle

There is a new implementation of this signal. Please review, @ShivprasadRoul

No response from @ShivprasadRoul. PR abandoned.

hortison avatar May 20 '25 21:05 hortison

Hi @vishalvivekm, I am interested in taking up this issue. Can you please assign me this?

avni-mahajan avatar Jul 29 '25 02:07 avni-mahajan