docs icon indicating copy to clipboard operation
docs copied to clipboard

Broken hyperlink - embedding designs

Open leecalcote opened this issue 1 year ago โ€ข 6 comments

Current Behavior

This section has a broken hyperlink - https://docs.layer5.io/meshmap/designer/export-designs/#exporting-as-embedding

Expected Behavior

Replace with new page location.


Contributor Guide and Resources

leecalcote avatar Aug 09 '24 21:08 leecalcote

Hey @leecalcote, Can you assign me this issue ? I have understood the task and am ready to get started.

kaushiktak19 avatar Aug 10 '24 17:08 kaushiktak19

@kaushiktak19 May I know if you have the website setup and working locally?

hargunkaur286 avatar Aug 10 '24 20:08 hargunkaur286

Hi @leecalcote and @hargunkaur286 ,

I've set up the documentation site locally and have addressed the broken hyperlink issue. Iโ€™ve verified the fix and created a video demonstrating the changes and how the link now correctly points to the updated page location.

Could you please review the video to ensure the fix aligns with whatโ€™s needed? If everything looks good, Iโ€™m ready to proceed with committing the changes and creating a pull request.

https://github.com/user-attachments/assets/b0afea9c-3408-4a81-9263-c4e87138e557

Also, could I be assigned this issue so I can track it more effectively?

kaushiktak19 avatar Aug 11 '24 05:08 kaushiktak19

Go ahead @kaushiktak19 . Please add also as a agenda item for today in website meet here: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit so lets discuss this. Please join at 5:30pm IST

sudhanshutech avatar Aug 12 '24 10:08 sudhanshutech

Sure @sudhanshutech, I will join the meet and will be raising a PR for this issue soon.

kaushiktak19 avatar Aug 12 '24 12:08 kaushiktak19

Hey @sudhanshutech @leecalcote @hargunkaur286, I have raised a PR for fixing this issue, do let me know if it is ready to go or something else is needed from my side.

kaushiktak19 avatar Aug 13 '24 06:08 kaushiktak19