rust-eventsource-client icon indicating copy to clipboard operation
rust-eventsource-client copied to clipboard
verified publisher icon launchdarkly

FEAT: Return headers of connection start

Open Zarathustra2 opened this issue 3 years ago • 1 comments

Hi there,

Noticed there was no way to access the headers from the connection creation so I added that in.

The use case here is that we connect that our providers adds a session cookie in the headers which we need to extract to update the stream (add/remove subscriptions)

Best regards, Dario

Zarathustra2 avatar Nov 26 '22 21:11 Zarathustra2

Hi Dario, thank you for the PR!

Due to time constraints, we might be a bit slow in reviewing and/or merging this at the moment.

Filed internally as 178073.

cwaldren-ld avatar Nov 29 '22 17:11 cwaldren-ld

@Zarathustra2 thank you for your patience.

Both you and another developer have contributed PRs providing some similar behavior. I have merged your work, along with theirs, into a new PR (https://github.com/launchdarkly/rust-eventsource-client/pull/79) and included some adjustments we would also like to make.

I'm going to close this PR and keep all communication focused on that new PR.

Once again, thank you for your contribution and I look forward to hearing if this new PR works for you.

keelerm84 avatar Jul 26 '24 21:07 keelerm84