react-native-client-sdk icon indicating copy to clipboard operation
react-native-client-sdk copied to clipboard
verified publisher icon launchdarkly

add tvOS target

Open todorone opened this issue 3 years ago • 2 comments

We successfully use LaunchDarkly SDK for tvOS platform, it's fully compatible. This change is the only thing that is required for successful compilation.

todorone avatar Sep 07 '22 09:09 todorone

Hello @todorone, thank you for the contribution! Because LaunchDarkly React Native SDK uses the LaunchDarkly iOS SDK as the native module for iOS (which supports tvOS), it is good that this works out for you.

We will discuss this with the React Native and iOS engineers, and if it makes sense, port the test (https://app.circleci.com/pipelines/github/launchdarkly/ios-client-sdk/95/workflows/74b1aea7-374f-425f-9a6f-8288b16e6cd3/jobs/635) into React Native SDK and accept the change.

louis-launchdarkly avatar Sep 07 '22 21:09 louis-launchdarkly

Hello @todorone, thank you for the contribution! Because LaunchDarkly React Native SDK uses the LaunchDarkly iOS SDK as the native module for iOS (which supports tvOS), it is good that this works out for you.

We will discuss this with the React Native and iOS engineers, and if it makes sense, port the test (https://app.circleci.com/pipelines/github/launchdarkly/ios-client-sdk/95/workflows/74b1aea7-374f-425f-9a6f-8288b16e6cd3/jobs/635) into React Native SDK and accept the change.

thanks a lot, @louis-launchdarkly

what is approximate timeline for this - days, months, years, centuries? 😸

todorone avatar Sep 22 '22 05:09 todorone