sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

update rustls dependency and make edits to support its api changes

Open avtrujillo opened this issue 1 year ago • 1 comments

The rustls crate made some significant changes to its api in v0.23.0, as summarized in the release notes. This pull request bumps the versions of the rustls, rustls-pemfile, and webpki-roots crates, and makes a number of changes needed in response to the aforementioned api changes.

There is, unfortunately, an important drawback to consider. The v0.23.0 release introduced process-wide selection of crypto providers, which requires either that A) we make a breaking api change that requires users to pass in a CryptoProvider when creating a ClientConnection or that B) the user calls CryptoProvider::install_default() exactly once. This pull request does not implement option A, nor does it include the documentation necessary for users to make option B work. I'm interested in adding the documentation for B and maybe trying to figure out some way of putting A behind a feature gate if desired, but I wanted to get feedback first.

avtrujillo avatar May 07 '24 21:05 avtrujillo

Realizing now that this is very similar to the changes made in this branch, which is a couple months behind main

avtrujillo avatar May 10 '24 11:05 avtrujillo

@avtrujillo can you rebase to re-run CI please?

abonander avatar Jul 16 '24 00:07 abonander

Superseded by #3399

abonander avatar Aug 02 '24 23:08 abonander