sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Chrono dependency in 0.7.4 release

Open mirek26 opened this issue 1 year ago • 3 comments

Bug Description

Trying to update to 0.7.4 and seeing:

error[E0432]: unresolved import `chrono::TimeDelta`

This is because sqlx specifies a dependency on chrono 0.4.22 but actually depends on 0.4.34 (https://github.com/chronotope/chrono/commit/ac383d5303f732a3ab27e6c2d94fd5ee9895f52c). Bumping chrono dependency in my project resolved this but I should not need to do that

Minimal Reproduction

Info

  • SQLx version: 0.7.4
  • SQLx features enabled: postgres, chrono, runtime-tokio
  • Database server and version: Postgres
  • Operating system: mac os
  • rustc --version: 1.75

mirek26 avatar Mar 14 '24 14:03 mirek26

Ah, this is the trap of just running cargo update in a library. It updated chrono locally and for CI, and introduced deprecation warnings that I was then forced to fix because of -D warnings.

abonander avatar Mar 14 '24 18:03 abonander

We could fix the chrono dependency and kick out a hotfix, but given that the fix either way is to run cargo update, it doesn't seem hugely necessary.

abonander avatar Mar 17 '24 22:03 abonander

Had the same exact issue. Can confirm that cargo update fixed the issue.

Mouwrice avatar Mar 20 '24 15:03 Mouwrice