sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Support schema in custom postgres type names, generate PgHasArrayType impls for enums

Open rex-remind101 opened this issue 2 years ago • 7 comments

Fixes https://github.com/launchbadge/sqlx/issues/2595, https://github.com/launchbadge/sqlx/issues/2262, and https://github.com/launchbadge/sqlx/issues/1576.

replaces https://github.com/launchbadge/sqlx/pull/2641

rex-remind101 avatar Sep 29 '23 19:09 rex-remind101

Adding a generated impl to the derive is unfortunately a breaking change as it conflicts with any manually added impl. We've learned this the hard way.

abonander avatar Oct 04 '23 20:10 abonander

should we add a separate derive then? and should we split off the first commit into a separate pr? what's the best path forward you think?

rex-remind101 avatar Oct 06 '23 19:10 rex-remind101

can anyone merge this pr? its very important fix

mymtw avatar Oct 28 '23 17:10 mymtw

It would be great to have this, maybe the fetch_type_by_oid changes could be split off. I would be happy too, but not want to step on any one's toes. 😄

joseph-isaacs avatar Nov 09 '23 22:11 joseph-isaacs

bump

mymtw avatar Mar 26 '24 05:03 mymtw

@abonander will we see this fix merged?

mymtw avatar Mar 27 '24 00:03 mymtw

@abonander will we see this fix merged?

mymtw avatar Mar 27 '24 22:03 mymtw

Superceded by #3252

abonander avatar Jun 15 '24 18:06 abonander