jose icon indicating copy to clipboard operation
jose copied to clipboard

Clean up some FreeBSD conditions

Open hdholm opened this issue 4 years ago • 1 comments

Relatively small changes to check for host_machine vs. build_machine as the target to account for possible cross compilation. Additionally removes some explicit dependencies on OpenSSL for FreeBSD which required OpenSSL to be installed via pkg or ports rather than relying on the "built-in" OpenSSL version shipped by default. Consequently discovered that the issue-75 test depends on version 1.1.0 or higher of OpenSSL being installed on the build machine for OPENSSL_init_ssl, .so made that explicit in the dependency.

hdholm avatar Jul 04 '21 22:07 hdholm

Hello @hdholm. Thanks for PR. Changes LGTM. Please, could you rebase on top of the current tree to fix the conflicts? Thanks in advance

sarroutbi avatar Oct 06 '21 12:10 sarroutbi

The CI checks are stalled on this, which I believe is fixed by PR #129

hdholm avatar May 08 '23 00:05 hdholm

Hello @hdholm. Thanks for the PR. A new release of jose is being planned and we would like this change to be merged ... would you mind fixing the conflicts? Or do you prefer me to do it? I am OK with both.

sarroutbi avatar Feb 01 '24 14:02 sarroutbi

As conflict is easily fixable, I will sort it out myself. Thanks for your PR @hdholm.

sarroutbi avatar Feb 02 '24 09:02 sarroutbi

Thanks for taking care of it. It's been a very busy week. Just catching up on email now.

hdholm avatar Feb 02 '24 12:02 hdholm