latchset
passing args to 'cryptsetup open'
Quick attempt to allow passing of arbitrary args to 'cryptsetup open' when unlocking volume. Related to the discussion here.
This is just a quick, minimally-tested version, so feel free to give feedback here, if I've made any egregious errors, etc.
@sergio-correia @sarroutbi Is there anything I can do to shepherd this process along? It's not so urgent that it must happen now or anything. I just wasn't sure what kind of timeframe I could expect something to happen. It's fine if it takes a while, but it would be helpful to know, even roughly, how long it is likely to take.
@sergio-correia @sarroutbi Is there anything I can do to shepherd this process along? It's not so urgent that it must happen now or anything. I just wasn't sure what kind of timeframe I could expect something to happen. It's fine if it takes a while, but it would be helpful to know, even roughly, how long it is likely to take.
Hello @somewhere-or-other. In my opinion, this could be merged, but I would prefer @sergio-correia to review it. By the way, thank you very much for adding a unit test associated to this new option.
@sergio-correia, @sarroutbi
I realize it's been a while for this PR, but I'd still love to see it get merged, if possible. We're starting to see more and more use cases for it, via the related ClusterLabs PR. I'm happy to re-work it if there's a problem you can identify.
@sarroutbi You're absolutely right. I totally forgot to do that. Should be there now.
I'm reviewing the logs from last night's failed build tests. Given that my test seems to have passed, and another one was the one that failed, this seems like a more general problem, either with the code base, or the testing infrastructure.
If I'm wrong, please let me know, and I'll do my best to fix it.
I'm reviewing the logs from last night's failed build tests. Given that my test seems to have passed, and another one was the one that failed, this seems like a more general problem, either with the code base, or the testing infrastructure.
If I'm wrong, please let me know, and I'll do my best to fix it.
Let me re-run all the jobs and let's check. I agree this seems more related to testing infrastructure.
This is super useful, but I don't see it in any release yet. Is that right?
@sarroutbi, @sergio-correia, could we get a release with this, please? So that this will eventually end up in distributions.
Hello @mvollmer . We have some pending PRs that need to be reviewed. Once merged, we will create the new release.
Hello @mvollmer . We have some pending PRs that need to be reviewed. Once merged, we will create the new release.
Thank you!