Add preliminary support for instrumenting Express v5
Adds preliminary support for Express v5 by:
- Wrapping around express.Router.prototype instead of express.Router, since in v5 express.Router.use() doesn't exist;
- Sets the redMiddlewareAdded flag on a per router basis;
Hey @davidfoliveira, Appreciate the pull request ❇️
We are recommending folks to use OpenTelemetry SDKs for metrics these days. Are you using OpenAPM?
Hey @davidfoliveira, Appreciate the pull request ❇️
We are recommending folks to use OpenTelemetry SDKs for metrics these days. Are you using OpenAPM?
Hi @prathamesh-sonpatki ! Yes, my team is using it on an internal project integrated with Parse Server. However, since the latest version of Parse Server uses express v5 we stopped having service metrics. We believe this change will allow it to work again.
Have you also verified it works for Express 4? I am okay to cut a release for Express 5 if it is not backward compatible.
@prathamesh-sonpatki It was initially meant to be backwards compatible but it wasn't. Now it's working with both express v4 and v5