nefarious icon indicating copy to clipboard operation
nefarious copied to clipboard
verified publisher icon lardbit

Possibility to select "HDR" as a quality option

Open jordyvandomselaar opened this issue 4 years ago • 9 comments

Original discussion: https://github.com/lardbit/nefarious/discussions/96

It would be really cool if it was possible to select "HDR" as a quality preset. Right now it is possible to select ultra-hd which selects 4k content but it does not select 4k HDR content.

Because of this I have to use the manual search every time I'd like to get HDR content.

Thanks in advance!

jordyvandomselaar avatar Mar 17 '21 15:03 jordyvandomselaar

Thanks for creating this issue. Can you tell me which specific tags you look for when trying to get "4k hdr"? These quality labels aren't totally clear to me. Do you think "RAW HD" is synonymous with "4k HDR"?

lardbit avatar Mar 17 '21 16:03 lardbit

I think my confusion is that "HDR" is not a quality per se. 720p, 1020p, etc are qualities. nefarious groups qualities and sources (i.e bluray, webrip) into quality "profiles". I'm trying to wrap my head around how to best integrate "HDR". If you have any ideas, please send them along.

lardbit avatar Mar 17 '21 17:03 lardbit

As far as I can see it's usually in the name. HDR is not really a quality profile because any resolution can also have HDR. I think it's more of an additional setting on top of quality.

jordyvandomselaar avatar Mar 19 '21 15:03 jordyvandomselaar

That makes sense. I wonder if nefarious should include check boxes in addition to quality profiles to further specify: HDR, RawHD etc since they're not qualities themselves.

On Fri, Mar 19, 2021, 10:18 AM jordyvandomselaar @.***> wrote:

As far as I can see it's usually in the name. HDR is not really a quality profile because any resolution can also have HDR. I think it's more of an additional setting on top of quality.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lardbit/nefarious/issues/97#issuecomment-802908768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKYIKNASLXS2PXDAVA4OEL3TENTLFANCNFSM4ZKYZPBA .

lardbit avatar Mar 19 '21 15:03 lardbit

That would be awesome =)

jordyvandomselaar avatar Mar 19 '21 17:03 jordyvandomselaar

Alright, I'm sold on the idea. I'll keep this issue open until I have some time to tackle it, but my current idea is to keep the existing profiles but then include checkboxes for "modifiers". The radarr projects uses these but I don't really understand all of them and will at least include "HDR":

  • REGIONAL
  • SCREENER
  • RAWHD
  • BRDISK
  • REMUX

lardbit avatar Mar 19 '21 20:03 lardbit

Alright, I'm sold on the idea. I'll keep this issue open until I have some time to tackle it, but my current idea is to keep the existing profiles but then include checkboxes for "modifiers". The radarr projects uses these but I don't really understand all of them and will at least include "HDR":

  • REGIONAL
  • SCREENER
  • RAWHD
  • BRDISK
  • REMUX

This Wiki explains them pretty well: https://en.wikipedia.org/wiki/Pirated_movie_release_types

Clickbaitcake avatar Dec 31 '21 00:12 Clickbaitcake

Thanks @Clickbaitcake, that's definitely helpful. I plan on downloading sonarr at some point to mirror some of it's quality profile logic when I'm ready to tackle this.

lardbit avatar Jan 01 '22 22:01 lardbit

I think HDR is a value of a color-space property, in the same way that 1080 is a value of a vertical-resolution property.

So 1080p should inform the vertical-resolution and refresh-rate properties, and HDR should inform the colour-space property.

Then there is the bit-rate property, the remuxed property, the source (cam, hdr, etc.), and subtitle-language and audio-language properties.

None of these alone tell you the overall quality, but that could be calculated by combining the different properties.

lee-b avatar Jul 26 '22 11:07 lee-b