Fierro icon indicating copy to clipboard operation
Fierro copied to clipboard

MPI for the refactor

Open Adrian-Diaz opened this issue 5 months ago • 2 comments

Description

Type of change

Please select all relevant options

  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Formatting and/or style fixes
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

  • [x] Test A : regression tests and example SGH 2D and 3D runs
  • [ ] Test B :

Test Configuration:

  • OS version: WSL2 Ubuntu 20
  • Hardware: desktop
  • Compiler: gcc

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] The code builds from scratch with my new changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Adrian-Diaz avatar Sep 24 '25 15:09 Adrian-Diaz

Does the regression test suite pass on a GPU?

nathanielmorgan avatar Sep 26 '25 17:09 nathanielmorgan

Everything works now except the contact tests on cuda, its unclear why they'd pass on openmp but not cuda since I can verify all the state information going into the contact routines is concurrent.

Adrian-Diaz avatar Sep 28 '25 15:09 Adrian-Diaz