dify icon indicating copy to clipboard operation
dify copied to clipboard

Add VESSL AI OpenAI API-compatible model provider and LLM model

Open larcane97 opened this issue 1 year ago • 3 comments

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

  • [ ] Please open an issue before creating a PR or link to an existing issue
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

  • add new vessl ai model provider
  • add open api url postfix in OAIAPICompatLargeLanguageModel
    • ref : effccc64bb791356baf0f5dc6ae2b1cc71143a8e

🔔 Not Yet added yaml configuration. It'll be added within a week.

  • after adding, this comment will be deleted

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] test_validate_credentials
  • [x] test_invoke_model
  • [x] test_invoke_stream_model
  • [x] test_get_num_tokens

larcane97 avatar Oct 18 '24 03:10 larcane97

It seems that you forgot to add the yaml file? This is necessary, otherwise frontend will not be able to render the icon and display the model name and other information as expected.

Yeuoly avatar Oct 18 '24 09:10 Yeuoly

@Yeuoly yes right as I mentioned above, the yaml file isn't applied yet. I'll apply yaml file as soon as possible I just wanted to ask you code level review ! once applying yaml file, I'll notify you again. thank you :)

larcane97 avatar Oct 20 '24 07:10 larcane97

@Yeuoly Hello Yeouly, i added yaml file and assets then i think all i have to add is done, so can you review this pr?

larcane97 avatar Oct 23 '24 00:10 larcane97