dify icon indicating copy to clipboard operation
dify copied to clipboard

feat: add format util unit and add pre-commit unit check

Open LLmoskk opened this issue 1 year ago • 0 comments

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

  • [ ] Please open an issue before creating a PR or link to an existing issue
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

I added a check during pre commit to see if any functions in the utilits path have been incorrectly modified, causing single test failures, and supplemented the unit test file for format.ts

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update, included: Dify Document
  • [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Annotate the function in web/tiles/format.ts and then gcmsg "test: test pre commit" will trigger a unit check failure, reminding developers to check their modifications

LLmoskk avatar Sep 14 '24 07:09 LLmoskk