langgenius
feat: couchbase integration
Checklist:
[!IMPORTANT]
Please review the checklist below before submitting your pull request.
- [x] Please open an issue before creating a PR or link to an existing issue
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I ran
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.
Fixes #5178
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update, included: Dify Document
- [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
- [ ] Dependency upgrade
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- Tested test_vdb, docker-compose.yaml, docker-compose.middleware.yaml
Hello @JohnJyong, do you have any comments? The only issue left to be fixed is disabling embedding models with a dimensionality > 2048. I'd like to ideally throw an error like this but I'm not sure how other vdb's like relyt are handling it
@roadgoat19 Hello , sorry for the late response, we have working on some new features regarding RAG recently. Please resolve the conflicts and we can proceed with this PR. :)
@crazywoola I've fixed a lingering merge conflict, could you rerun the workflows please?
Hello the API Tests (3.10) failed and there are some lint errors in the superlinter.
You could run ./dev/reformat to resolve linting issues. @roadgoat19
@crazywoola Hello I believe I've fixed this issue causing the api tests to fail. However, I am a little unsure about how to fix the linter errors in the .env.example. When I run dev/reformat, it says that basically every single key is out of order. This issue persists even with the .env.example taken straight from the current main branch of dify. Is there a command I can run to fix this issue /or how should I proceed?
Hello there are some conflicts here. And still got a lint error. I think you need to upgrade ruff and sync deps by ./dev/sync-poetry.
Thanks @crazywoola, and sorry for the delay here. I'm picking this PR up for @roadgoat19, and have resolved all conflicts and updated the dependencies. Let me know if anything else needs adjusting!
Hello @ejscribne Thanks for picking this up, please resolve those conflicts again :)
Hey @crazywoola just fixed the conflicts, let me know if anything else needs to be done. Thanks!
I have resolved the conflicts in poetry.lock and fixed lint errors as well.
@ejscribner https://github.com/langgenius/dify/actions/runs/11285975856/job/31389592906?pr=6165 The tests are failed.
Hey @crazywoola sorry for the delay fixing this, added a healthcheck to be sure the resource is ready for the tests. It should fix the issue.