dify icon indicating copy to clipboard operation
dify copied to clipboard

fix: remove deprecated UnsafeUnwrappedHeaders usage

Open 17hz opened this issue 5 months ago • 1 comments

Summary

This PR fixes TypeScript deprecation warnings by removing the usage of deprecated UnsafeUnwrappedHeaders type in GA and Zendesk components.

Changes:

  • Updated web/app/components/base/ga/index.tsx to use modern Next.js 15 async headers() API
  • Updated web/app/components/base/zendesk/index.tsx to use modern Next.js 15 async headers() API
  • Removed deprecated UnsafeUnwrappedHeaders type imports and type casting
  • Made both components async to properly await the headers() promise

Technical Details: In Next.js 15, the headers() function returns a Promise that should be awaited, and the UnsafeUnwrappedHeaders type has been deprecated. This change updates the code to follow the recommended modern approach.

Screenshots

N/A - This is a TypeScript/deprecation fix with no visual changes

Checklist

  • [ ] This change requires a documentation update, included: Dify Document
  • [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [x] I've updated the documentation accordingly.
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

🤖 Generated with Claude Code

17hz avatar Nov 14 '25 05:11 17hz

Summary of Changes

Hello @17hz, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses TypeScript deprecation warnings by modernizing the usage of Next.js headers() API within the Google Analytics and Zendesk components. It ensures compatibility with Next.js 15's updated asynchronous headers() function, removing deprecated type usage and making the components asynchronous to properly handle the Promise-based API. The change is purely technical, focusing on code modernization and warning resolution, with no functional or visual impact on the application.

Highlights

  • Deprecated Type Removal: Eliminated the use of the deprecated UnsafeUnwrappedHeaders type and its associated type casting from relevant components.
  • Next.js 15 API Adoption: Updated the Google Analytics (GA) and Zendesk components to utilize the modern Next.js 15 async headers() API.
  • Asynchronous Components: Converted both the GA and Zendesk functional components to async functions to correctly await the Promise returned by the headers() API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 14 '25 05:11 gemini-code-assist[bot]