dify icon indicating copy to clipboard operation
dify copied to clipboard

fix: fixed workflow as tool files field return empty problem

Open CrabSAMA opened this issue 3 months ago • 1 comments

[!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes https://github.com/langgenius/dify/issues/26431

Add message.meta check, which is File instance and mark it is file link message, add it into files field.

Screenshots

Before After
imagefiles field is empty imagefiles field have correct content

Checklist

  • [ ] This change requires a documentation update, included: Dify Document
  • [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [x] I've updated the documentation accordingly.
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

CrabSAMA avatar Nov 06 '25 10:11 CrabSAMA

Summary of Changes

Hello @CrabSAMA, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the workflow tool processing where file attachments were not being correctly recognized and populated in the output's 'files' field. The changes introduce robust handling for LINK type messages, specifically looking for File instances within the message metadata. This ensures that any files passed through the workflow are properly extracted, listed, and presented to the user, thereby fixing the empty files field problem and improving the reliability of file-related operations within workflows.

Highlights

  • Bug Fix: Resolved an issue where the 'files' field in workflow tool outputs was incorrectly returning empty, preventing proper display and handling of attached files.
  • File Link Recognition: Implemented new logic to accurately identify and process file links within ToolInvokeMessage.MessageType.LINK messages by checking the message.meta for a File instance.
  • File Inclusion: Ensured that identified File instances from message.meta are correctly appended to the files list, making them available in the workflow output.
  • Output Formatting: Updated the text stream output for file links to display 'File:' instead of 'Link:', providing clearer context for users.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 06 '25 10:11 gemini-code-assist[bot]