laminas-code icon indicating copy to clipboard operation
laminas-code copied to clipboard

Add setAttributes to ClassGenerator

Open jakublabno opened this issue 3 years ago • 6 comments

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

Please add support for attributes generation like it has place for DocBlockGenerator It should support one attributes or a group of them

#[Attribute1(arg: true)]
#[Attribute2]
class SampleClass implements
{
}

jakublabno avatar Aug 11 '22 16:08 jakublabno

Probably requires a dedicated AttributeGenerator: consider sending a patch/proposal.

Ocramius avatar Aug 11 '22 16:08 Ocramius

Should I leave compatibility with 7.4?

jakublabno avatar Aug 12 '22 08:08 jakublabno

Your pick: PHP 7.4 is almost dead, so you can drop it, if it helps development.

Ocramius avatar Aug 12 '22 08:08 Ocramius

See also #143

Ocramius avatar Aug 12 '22 08:08 Ocramius

https://github.com/laminas/laminas-code/pull/145

jakublabno avatar Aug 12 '22 13:08 jakublabno