cpp-lru-cache

cpp-lru-cache copied to clipboard

Is Unneeded code?

1

`_cache_items_map.erase(it);` Is the line of code redundent?

zh820952173

why don we implement lrucache in header files(.hpp)

1

I was wondering that lrucache should only declare function in header files and implement the declration in .cpp files such as lrucache.cpp

fengxiaohu

Is there any benchmarking?

2

We all know that hashmaps are cool, but It'd be interesting to see how exactly cool they are. I suggest writing a comparison with getting values from plain std::map and...

ghost

yperbasis

Move value in put()

6

Hi, While performing some benchmarks I noticed that inserted values are copied, which reduces insert performance. I'll create a pull request to move values into the cache.

dermojo

How can I iterate all keys and values without modification of lru?

1

Need to iterate all keys of storage for example if I want to display/save to file all visited file paths stored in lru. Why just not return _cache_items_list.cbegin() and _cache_items_list.cend()?

EugeneManushkin

Possible Solution

1

Thanks for the simple and efficient implementation! Here is my solution based on your work. ```cpp #pragma once #ifndef LEVIDB_LRU_CACHE_H #define LEVIDB_LRU_CACHE_H /* * Original File: lrucache.hpp * Original Author:...

JimChengLin

Project doesn't compile with Ninja

2

Steps to reproduce: ``` $ mkdir build $ cd build $ cmake -G Ninja .. [...] $ ninja ninja: error: 'ext/gtest/src/googletest-build/libgtest.a', needed by 'cpp-lru-cache-test', missing and no known rule to...

afiskon

Thread-safety

3

After a quick test using valgrind I'm experiencing invalid reads on a multithreaded application. Is this a bug or is your library only expected to work in a single-threaded environment?

knedlsepp

swiftcoder