Brian Campbell

Results 18 comments of Brian Campbell

Any chance that someone could review these and either pull them or let me know what I should do differently?

@yumitsu That's not the assertion which was failing. It was the ISO-8859-1 test below that was failing; the UTF-8 test worked, because the default external encoding is UTF-8, but when...

[Minimal repro](https://play.rust-lang.org/?gist=4a46a5793b957cd5733311c1e563463c&version=nightly&mode=debug&edition=2018): ``` use std::time::Duration; use serde_json; fn main () { let t = std::time::UNIX_EPOCH - Duration::new(1, 0); println!("{}", serde_json::to_string(&t).unwrap()); } ``` The relevant portion of the backtrace: ``` thread...

Yep, I figured that out after writing the previous comment, and started working on a patch to serde to fix it. My main concern is that `i128` was only fairly...

> Would it be a breaking change to switch to `i128` down the road, once it's better supported? I think it will always be a breaking change, as some formats...

I've pushed pull request #258 with a rebased version of #175 that also addresses the comments from @sjroe.

> why not updating the requires-python range, what is the value by the way? Because I'm running this in CI against dozens of packages maintained by different people at my...

I ran into this problem when I was in an elevated PowerShell prompt for an admin user who may not have ever logged in directly. This meant that winget wasn't...

So, at least in the Hachyderm case, I don't think any of the later steps are actually failing; they are just completing slowly. For example, I've replied to posts from...

> I don't think a status that failed to federate entirely can be considered working. True, but I haven't yet seen any cases where a post fails to federate; the...