echo icon indicating copy to clipboard operation
echo copied to clipboard

Allow colon in route after path param

Open evanrolfe opened this issue 1 month ago • 1 comments

The current router implementation does not allow for colons in the route if they are immediately following a path parameter, this prevents us from following the Google API specification.

For example, I was unable to define a route which would match a URL like this: POST /files/1234:delete where 1234 should map to a :fileId path param. This PR fixes that.

evanrolfe avatar Dec 09 '25 18:12 evanrolfe

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 94.04%. Comparing base (f24aaff) to head (8b6130a). :warning: Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2847      +/-   ##
==========================================
+ Coverage   93.25%   94.04%   +0.79%     
==========================================
  Files          39       39              
  Lines        4652     3826     -826     
==========================================
- Hits         4338     3598     -740     
+ Misses        218      134      -84     
+ Partials       96       94       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 09 '25 19:12 codecov[bot]