labml icon indicating copy to clipboard operation
labml copied to clipboard
verified publisher icon labmlai

Is there a flag to show all warnings including the ignored ones?

Open bonniesimon opened this issue 3 years ago • 5 comments

Is there a way to see the ignored warnings without removing their entry from the brakeman.ignore file?

I wanted to see the ignored cases in the cli itself. Is that currently possible?

bonniesimon avatar Mar 17 '23 05:03 bonniesimon

Ignored warnings are included in the JSON output (e.g. brakeman -f json).

That's the only good way right now.

presidentbeef avatar Mar 19 '23 16:03 presidentbeef

Would love to have a flag that would show all the warning including the ignored warning. I would love to contribute to that feature. Let me look into it.

But before that just give me your thoughts on such a flag.

bonniesimon avatar Mar 21 '23 07:03 bonniesimon

What's the desired behavior you are looking for?

  1. Ignore the ignore file
  2. Show all warnings, but ignored warnings are in a separate section or otherwise marked
  3. Show all warnings, but only return a non-zero exit code for unignored warnings

presidentbeef avatar Mar 24 '23 07:03 presidentbeef

I think 2. would be good. I'm not sure what 3. means.

bonniesimon avatar Mar 26 '23 12:03 bonniesimon

Works for me. --show-ignored or something like that.

presidentbeef avatar Apr 18 '23 21:04 presidentbeef