backend.ai icon indicating copy to clipboard operation
backend.ai copied to clipboard

fix: allow run command without files for exec and vfolder option

Open rjwharry opened this issue 3 years ago • 2 comments

This PR Fixes #705

  • allow no files when exec and vfolder option is supplied
  • run exec_loop function whether files are offered or not

rjwharry avatar Sep 12 '22 09:09 rjwharry

Please link this PR to the corresponding issue using one of these keywords, ["resolves", "closes", ...] (e.g. closes #ISSUE). This will close the linked issue automatically when this PR is approved and merged. For more information, please check this GitHub Docs.

By the way, thanks for the contribution!

rapsealk avatar Sep 12 '22 09:09 rapsealk

thank you for your contribute. But the purpose of --exec option is to execute the files, so I think we need to reconsider about the issue.

If the files are mounted with vfolder, then we don't have to upload explicitly. That's why I wanted to allow to use run command without uploading files when --exec and --mount options are enabled simultaneously

rjwharry avatar Sep 17 '22 07:09 rjwharry

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: achimnol
:x: rjwharry
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 26 '23 03:03 CLAassistant

This PR is not in urgency and has no activities for more than half a year. Feel free to post a new, improved PR. Closing this for now.

achimnol avatar May 15 '23 09:05 achimnol