Add additional drum kits

Open kylestetz opened this issue 7 years ago • 3 comments

The (drums) function can be extended to support a type argument, e.g. (drums 2), which controls what set of samples is played. A precedent around lazy loading each kit was already established in Drums.js; extending this should be easy and won't force users to download audio files unnecessarily.

Oct 02 '18 22:10 kylestetz

Wow ;D this is cool

Oct 03 '18 21:10 ghost

@kylestetz, are you thinking this will always draw samples from /public/audio/acoustic via loadDrumSounds and drumMap?

If I'm understanding that right, I'll take this one on!

Oct 08 '18 22:10 agbales

Hey @agbales, someone already started taking this on in PR #10! Happy to have you pop in there and give some additional feedback if you're interested. I will probably be very slow at responding to/merging anything in this project 😅

Oct 11 '18 01:10 kylestetz