Fuse.NET icon indicating copy to clipboard operation
Fuse.NET copied to clipboard

Fix/scoring

Open MichaelSearson opened this issue 6 years ago • 1 comments

What has changed

A new project has been added to the solution so that we can start migrating the unit tests across from the original Fuse repo.

At the moment this PR is not ready to merge as we only have the first 16, covering the base and book-fixture tests. This leaves 72 tests to port.

Note: I've also merged the master branch into this feature to keep it up to date.

Why

In order to assist with the investigation and resolution of issue #1 having the same tests as the original repo will assist greatly. Of the 16 mentioned above 12 are currently failing. Some may be mistakes on my part when writing the tests - but it gives a great starting point for narrowing down the problem described in the link above, and any other issues not yet confirmed.

Future Improvements

When we have a mirror of all the Fuse tests I can move on to investigating the scoring bug (assuming you have no objections of course). For now I'm wary of making any significant source changes without good test coverage!

Checklist before accepting

  • [X] There is a new assembly for NUnit tests
  • [ ] All unit tests have been migrated
  • [ ] Any bugs that exist in the original source have had issues raised in said repository.
  • [ ] Failing tests have been resolved where possible. If the change is particularly large it may be easier to split out into a new PR. To be discussed as and when necessary.
  • [ ] We have good test coverage (I plan on using something like Open Cover to verify this)

MichaelSearson avatar Jan 05 '20 17:01 MichaelSearson