Use Docsy-friendly section partial
Use a partial for <section> that will work with near-vanilla Docsy.
Helps with issue #41171.
Preview of the updated page.
There are two kinds of CSS change.
- Fixes for the video section to make it display about right after the update.
- Hiding the KubeWeekly sign up link (see https://github.com/kubernetes/website/pull/51829)
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | bd7dc226d0bb620759ecddbac6c5c0b258f1dd0d |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/698390c11d534000087224c0 |
| Deploy Preview | https://deploy-preview-51969--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Oh, hmm. It worked on my machine when I previewed it.
/retitle [WIP] Use Docsy-friendly section partial
/retitle Use Docsy-friendly section partial
@dipesh-rawat @natalisucks this is ready for a review (I hope - it works on my machine)
Actually, https://github.com/kubernetes/website/pull/51829 drops KubeWeekly.
@dipesh-rawat @natalisucks would you folks be willing to review this one?
thanks for this @lmktfy! really appreciate you working out some of the background issues if you have time @dipesh-rawat and want to approve this change, that would be great
/lgtm
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dipesh-rawat
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dipesh-rawat]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment