website icon indicating copy to clipboard operation
website copied to clipboard

Use Docsy-friendly section partial

Open lmktfy opened this issue 8 months ago • 7 comments

Use a partial for <section> that will work with near-vanilla Docsy.

Helps with issue #41171.

Preview of the updated page.

lmktfy avatar Aug 19 '25 20:08 lmktfy

There are two kinds of CSS change.

  1. Fixes for the video section to make it display about right after the update.
  2. Hiding the KubeWeekly sign up link (see https://github.com/kubernetes/website/pull/51829)

lmktfy avatar Aug 19 '25 20:08 lmktfy

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit bd7dc226d0bb620759ecddbac6c5c0b258f1dd0d
Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/698390c11d534000087224c0
Deploy Preview https://deploy-preview-51969--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Aug 19 '25 20:08 netlify[bot]

Oh, hmm. It worked on my machine when I previewed it.

/retitle [WIP] Use Docsy-friendly section partial

lmktfy avatar Aug 21 '25 17:08 lmktfy

/retitle Use Docsy-friendly section partial

@dipesh-rawat @natalisucks this is ready for a review (I hope - it works on my machine)

lmktfy avatar Sep 07 '25 14:09 lmktfy

Actually, https://github.com/kubernetes/website/pull/51829 drops KubeWeekly.

lmktfy avatar Oct 30 '25 21:10 lmktfy

@dipesh-rawat @natalisucks would you folks be willing to review this one?

lmktfy avatar Feb 02 '26 00:02 lmktfy

thanks for this @lmktfy! really appreciate you working out some of the background issues if you have time @dipesh-rawat and want to approve this change, that would be great

/lgtm

natalisucks avatar Feb 06 '26 11:02 natalisucks

LGTM label has been added.

Git tree hash: 057e8686ae9080183746bf1d9c6497c609fe463a

k8s-ci-robot avatar Feb 06 '26 11:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 06 '26 15:02 k8s-ci-robot