Registering apply-time-mutation annotation

[Ritikaa96]

Registering and adding config.kubernetes.io/apply-time-mutation on page :https://kubernetes.io/docs/reference/labels-annotations-taints/

Fixes: #42151

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/docs/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Ritikaa96]

/sig docs /kind bug

[Ritikaa96]

@sftim, Hey! PTAL. Although I guess we have already reviewed the last PR to define the content. Let me know if any change is needed.

[netlify[bot]]

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	8bdda095fde62beaff3a8f80a8e5972b63e17ef0
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a1d939e389720008c57e02
😎 Deploy Preview	https://deploy-preview-47267--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Ritikaa96]

I do not know much about the relevance of the link but think this might be of some reference : https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/apply/mutator/apply_time_mutator.go Sig cli utils has this code and some test files also mentions it.

[Ritikaa96]

Any update on this PR review ? @sftim @drnic ?

[sftim]

/lgtm

I think this is used enough in-project that we should register it.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c58bc2208b7d22ecb19f71157a2da2861b266092

[Ritikaa96]

@reylejano @windsonsea , Hi

Any update on this? Is there any more changes i need to make in the PR?

[natalisucks]

@kubernetes/sig-architecture @kubernetes/sig-cli-leads hi folks – I'd love a tech review here to ensure this annotation can be docmented and merged, thanks!

[soltysh]

This annotation is not part of the default k8s distribution. It exists in cli-utils, but that part of the code is not even part of our vendored directory. So with my sig-cli TL hat I'd say we don't mention this here.

[nate-double-u]

This annotation is not part of the default k8s distribution. It exists in cli-utils, but that part of the code is not even part of our vendored directory. So with my sig-cli TL hat I'd say we don't mention this here.

Thanks for the review @soltysh.

Thanks for the work on this @Ritikaa96, but with a Tech Lead suggesting we not make this change, I'm closing this PR.

/close

[k8s-ci-robot]

@nate-double-u: Closed this PR.

In response to this:

This annotation is not part of the default k8s distribution. It exists in cli-utils, but that part of the code is not even part of our vendored directory. So with my sig-cli TL hat I'd say we don't mention this here.

Thanks for the review @soltysh.

Thanks for the work on this @Ritikaa96, but with a Tech Lead suggesting we not make this change, I'm closing this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sftim]

This annotation is not part of the default k8s distribution. It exists in cli-utils, but that part of the code is not even part of our vendored directory. So with my sig-cli TL hat I'd say we don't mention this here.

BTW, we register annotations even when they're not in core Kubernetes but do exist in shipped code. Anyway it sounds like nothing we ship has ever used this annotation, and no registration is needed.