website icon indicating copy to clipboard operation
website copied to clipboard

Add feature gate for APIServingWithRoutine in v1.30

Open tengqm opened this issue 1 year ago β€’ 4 comments

tengqm avatar Jul 24 '24 11:07 tengqm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 24 '24 11:07 k8s-ci-robot

Pull request preview available for checking

Name Link
Latest commit 59aec477d287013afa31d61017072db0e397f156
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a0e2fa6f268c0008da444c
Deploy Preview https://deploy-preview-47253--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 24 '24 11:07 netlify[bot]

Pull request preview available for checking

Name Link
Latest commit 05ac0e969ab5ac07932649a3c0ce27374c8d7d02
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a47d2b49e18b0008734b1a
Deploy Preview https://deploy-preview-47253--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 24 '24 11:07 netlify[bot]

Again, LGTM for docs

sftim avatar Jul 30 '24 19:07 sftim

cc: @linxiulei @kubernetes/sig-api-machinery-misc

We have a LGTM from Docs - can we please get a technical review of this feature gate doc? If any details need adding for optimal clarity of this for our users, please let us know. We appreciate it, thanks!

drewhagen avatar Jul 31 '24 17:07 drewhagen

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 30 '24 13:10 k8s-triage-robot