website icon indicating copy to clipboard operation
website copied to clipboard

Fix multiple typos under "content/en/docs/reference"

Open n0vad3v opened this issue 1 year ago • 7 comments

Fix multiple typos under content/en/docs/reference

Some backgrounds on how theses typos are fixed, I've wrote a (Chinese) blog about this: https://nova.moe/fast-typo-fix/ (English version: https://nova.moe/fast-typo-fix-en/) 😇

n0vad3v avatar May 04 '24 12:05 n0vad3v

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 04 '24 12:05 k8s-ci-robot

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit b67ba6e99485a4cd7485ac7e522599ad4686e9e0
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6636244977ad130008ad1474
Deploy Preview https://deploy-preview-46178--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 04 '24 12:05 netlify[bot]

/lgtm

Thanks!

stmcginnis avatar May 04 '24 12:05 stmcginnis

LGTM label has been added.

Git tree hash: 3b250fb26c253daf6f7525997835889a49dae34a

k8s-ci-robot avatar May 04 '24 12:05 k8s-ci-robot

/retitle Fix multiple typos under "content/en/docs/reference"

We avoid markdown in commit messages.

dipesh-rawat avatar May 04 '24 13:05 dipesh-rawat

/hold

Refer https://github.com/kubernetes/website/pull/46178#pullrequestreview-2039349602 Instead of modifying the generated pages directly, it would be more effective to either regenerate all the reference documentation incorporating upstream fixes or consider excluding the auto-generated pages from this pull request altogether.

Feel free to unhold this once either of the above actions has been taken.

dipesh-rawat avatar May 04 '24 13:05 dipesh-rawat

Thanks @dipesh-rawat , I've created a PR at https://github.com/kubernetes/kubernetes/pull/124696 which will fix those typos in upstream.

n0vad3v avatar May 05 '24 13:05 n0vad3v

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 03 '24 14:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 02 '24 14:09 k8s-triage-robot

The changes proposed in this PR will be overwritten as these files are auto generated. The changes should be at the source

reylejano avatar Sep 03 '24 18:09 reylejano

With this PR's current lifecycle state "lifecycle/rotten" and the changes proposed here are for autogenerated files and should be changed at their source instead, I'm closing this PR Feel free to reopen this PR with /reopen in a comment if you feel otherwise /close

reylejano avatar Sep 03 '24 18:09 reylejano

@reylejano: Closed this PR.

In response to this:

With this PR's current lifecycle state "lifecycle/rotten" and the changes proposed here are for autogenerated files and should be changed at their source instead, I'm closing this PR Feel free to reopen this PR with /reopen in a comment if you feel otherwise /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 03 '24 18:09 k8s-ci-robot