website icon indicating copy to clipboard operation
website copied to clipboard

Remove ReadWriteOncePod feature gate

Open chrishenzie opened this issue 1 year ago • 6 comments

This feature is GA and its feature gates will be removed in v1.31: https://github.com/kubernetes/kubernetes/pull/124329

Following instructions in: https://kubernetes.io/docs/contribute/new-content/new-features/#ready-for-review-feature-gates

/assign sftim /assign carlory

chrishenzie avatar May 01 '24 21:05 chrishenzie

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit d84a36be9e2e722ab45b784f1549b329e14c3a4f
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66390375c7748c00086c9e2a

netlify[bot] avatar May 01 '24 21:05 netlify[bot]

LGTM label has been added.

Git tree hash: 2f4d43cc42030d2b1ea03200a22ef9613a5fe09a

k8s-ci-robot avatar May 01 '24 21:05 k8s-ci-robot

Docs looks okay, but the upstream change is not yet merged. Please add a link to the upstream PR. /hold

tengqm avatar May 02 '24 03:05 tengqm

Upstream PR here: https://github.com/kubernetes/kubernetes/pull/124329, also added to description

chrishenzie avatar May 02 '24 16:05 chrishenzie

/approve Change looks good. Feel free to lift the hold when the upstream change is in.

tengqm avatar May 03 '24 11:05 tengqm

/approve cancel

tengqm avatar May 06 '24 07:05 tengqm

/approve but /hold again for upstream code readiness.

tengqm avatar May 06 '24 22:05 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 06 '24 22:05 k8s-ci-robot

/assign @Princesso

reylejano avatar May 15 '24 14:05 reylejano

LGTM label has been added.

Git tree hash: df987d6507342e5a3fe4365e3b2c2878064ce960

k8s-ci-robot avatar May 15 '24 15:05 k8s-ci-robot

/hold cancel

upstream pr is merged

carlory avatar Jun 13 '24 02:06 carlory