release icon indicating copy to clipboard operation
release copied to clipboard

Add CVSS v4.0 support, fix CVSS v2.0 invalid calculator link

Open pandatix opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind feature /kind cleanup

What this PR does / why we need it:

FIRST.ORG SIG CVSS (which I'm part of) released CVSS v4.0 months ago, and we see adoption going on in the whole ecosystem. Nevertheless, Kubernetes is not ready yet to handle those new vectors... but not for long ! :tada:

Through this PR, I bring the possibility to handle CVSS v4.0 vector strings. Moreover, I fix the calculator link computation as the FIRST.ORG does not have a calculator for CVSS v2.0, which technically produced 404 URLs despite it is no longer used by the community.

Which issue(s) this PR fixes:

Did not open an issue for the CVSS v2.0 calculator link, though it was irrelevant as will affect people relying on CVSS v2.0 vector strings which will most likely be nobody.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

pandatix avatar Feb 19 '24 20:02 pandatix

Hi @pandatix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 19 '24 20:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pandatix Once this PR has been reviewed and has the lgtm label, please assign cici37 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 19 '24 20:02 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 27 '24 17:06 k8s-ci-robot

The NVD has now official support of CVSS v4.0 (https://nvd.nist.gov/general/news/cvss-v4-0-official-support), may be a good time to re-evaluate this PR.

pandatix avatar Jul 04 '24 09:07 pandatix

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 02 '24 09:10 k8s-triage-robot