git-sync test_e2e.sh: use `local` for all variables defined inside functions

Use local for all variables defined inside functions; also convert them all to common name style (lowercase for locals)

Originally posted by @thockin in https://github.com/kubernetes/git-sync/issues/902#issuecomment-2187270246

Jun 24 '24 20:06 rul

Hi @rul, thank you for the contribution, as I can observe the PR is merged now, so you can now close this issue.

Jul 15 '24 14:07 thisisharrsh

AFAICT, this is not done:

function assert_file_lines_eq() {
    N=$(wc -l < "$1")

function docker_run() {
    RM="--rm"

function init_repo() {
    arg="${1}"

function GIT_SYNC() {
    #./bin/linux_amd64/git-sync "$@"
    RM="--rm"

    # make a worktree to collide with git-sync
    SHA=$(git -C "$REPO" rev-list -n1 HEAD)

etc

Jul 15 '24 16:07 thockin

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Oct 13 '24 16:10 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jan 11 '25 23:01 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Apr 12 '25 06:04 k8s-triage-robot