kubernetes
Add dual-stack support for node-cache
Welcome @DockToFuture!
It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @DockToFuture. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Implementation-wise, it would be ideal to have a test for this new feature.
Project-wise, let's get an agreement on https://github.com/kubernetes/dns/issues/642 before merging this. I've just reopened it so that the discussion can continue.
@DamianSawicki How is #642, which is about graceful shutdown/readiness, related to supporting dual-stack, i.e. IPv4 and IPv6? As of now node-local-dns only supports exclusively either IPv4 or IPv6, but not both at the same time. To me, these two features seem to be rather orthogonal to each other.
Please advise.
@DamianSawicki How is #642, which is about graceful shutdown/readiness, related to supporting dual-stack, i.e. IPv4 and IPv6? As of now
node-local-dnsonly supports exclusively either IPv4 or IPv6, but not both at the same time. To me, these two features seem to be rather orthogonal to each other.Please advise.
I'm terribly sorry, I somehow confused PR https://github.com/kubernetes/dns/pull/669, which is related to Issue https://github.com/kubernetes/dns/issues/642, with the present PR. Please disregard my comment.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@DamianSawicki is there some interest in dual-stack support for node-cache, as there were no reactions for a long time? Then I will adapt the PR.
@DamianSawicki is there some interest in dual-stack support for node-cache, as there were no reactions for a long time? Then I will adapt the PR.
Thanks for a quick response @DockToFuture! From comments above and in https://github.com/gardener/gardener/pull/10891#pullrequestreview-2454282618, it looked that @ScheererJ was interested.
@Michcioperz @marqc, is dual-stack in node-cache something of interest to you?
It's a holiday season, so let's give it some more time.
/remove-lifecycle rotten
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: DockToFuture Once this PR has been reviewed and has the lgtm label, please assign damiansawicki for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hello @DamianSawicki, I've updated the pull request and addressed the feedback you provided.
I've seen when I check out master and execute the tests, that the test are failing with:
(⎈|kind-gardener-extensions:default)➜ app git:(master) go test
# k8s.io/dns/cmd/node-cache/app [k8s.io/dns/cmd/node-cache/app.test]
./cache_app.go:59:21: undefined: utiliptables.Table
./cache_app.go:60:21: undefined: utiliptables.Chain
./cache_app.go:66:29: undefined: utiliptables.Interface
./cache_app.go:117:18: undefined: utiliptables.Table
./cache_app.go:117:45: undefined: utiliptables.ChainPrerouting
./cache_app.go:119:18: undefined: utiliptables.Table
./cache_app.go:119:45: undefined: utiliptables.ChainPrerouting
./cache_app.go:123:18: undefined: utiliptables.TableFilter
./cache_app.go:123:44: undefined: utiliptables.ChainInput
./cache_app.go:152:44: undefined: utiliptables.Interface
./cache_app.go:123:44: too many errors
FAIL k8s.io/dns/cmd/node-cache/app [build failed]
This needs to be fixed upstream.
BR Sebastian