kubernetes
[occm] LoadBalancer ProxyProtocol v2 feature
What this PR does / why we need it: The PR brings the ability of choosing the ProxProtocol in version 2 (instead of v1).
Two new values are supported for loadbalancer.openstack.org/proxy-protocol
loadbalancer.openstack.org/proxy-protocol: "true" # Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "false" # Default value, no proxy protocol enable
loadbalancer.openstack.org/proxy-protocol: "v1" # NEW - Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "v2" # NEW - Enable ProxyProtocolv2
Which issue this PR fixes(if applicable): fixes #2585
Special notes for reviewers: N/A
Release note:
[openstack-cloud-controller-manager] Support LoadBalancer ProxyProtocol v2 feature
Hi @Lucasgranet. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@zetaab I'm not sure but E2E's failures seem not related to my PR.
Can you have a look please?
/test openstack-cloud-controller-manager-e2e-test /test openstack-cloud-controller-manager-ovn-e2e-test
@Lucasgranet can you rebase this pr against master? Master contain fixes for the e2e tests
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zetaab
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [zetaab]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
loadbalancer.openstack.org/proxy-protocol: "true" # Enable ProxyProtocolv1
from this comment I think default is still v1, correct ?
