cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard
verified publisher icon kubernetes

[manila-csi-plugin]: use new access rules GET method when possible

Open kayrus opened this issue 2 years ago • 19 comments

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

Some OpenStack deployments can have middlewares that limit an amount of POST/PUT requests, which are categorized as write requests. One of the wrongly categorized request is a deprecated list access rules action.

What you expected to happen:

In order to prevent excessive requests rate limiting, CSI Manila plugin should support a newer Manila API call.

How to reproduce it:

n/a

Anything else we need to know?:

See also https://github.com/terraform-provider-openstack/terraform-provider-openstack/issues/1582

Environment:

  • openstack-cloud-controller-manager(or other related binary) version: n/a
  • OpenStack version: n/a
  • Others: n/a

cc @Carthaca

kayrus avatar Jun 20 '23 15:06 kayrus

According to https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html#id40 it looks like this microversion has been available since Rocky which, according to https://releases.openstack.org/ is the oldest release which isn't EOL.

That said, if we bumped the minimum microversion to Rocky it still might make folks like @lentzi90 unhappy. We should discuss which versions of OpenStack we want to support.

mdbooth avatar Jun 20 '23 15:06 mdbooth

@mdbooth see a PR that corresponds to https://github.com/terraform-provider-openstack/terraform-provider-openstack/issues/1582. Before calling the share access list, we check API microversions.

kayrus avatar Jun 20 '23 15:06 kayrus

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 23 '24 00:01 k8s-triage-robot

/remove-lifecycle stale

gouthampacha avatar Jan 23 '24 00:01 gouthampacha

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 22 '24 01:04 k8s-triage-robot

/remove-lifecycle stale

gouthampacha avatar Apr 22 '24 14:04 gouthampacha

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 21 '24 15:07 k8s-triage-robot

/remove-lifecycle stale

kayrus avatar Jul 22 '24 06:07 kayrus