cloud-provider-openstack icon indicating copy to clipboard operation
cloud-provider-openstack copied to clipboard

[e2e] Factor out module test to simplify tooling

Open chrigl opened this issue 3 years ago • 8 comments

What this PR does / why we need it:

There are two "new" modules tests/e2e and tests/sanity. With them separated, the main go.mod is much cleaner and only contains dependencies for the "real" binaries. This makes maintenance a bit easier.

Because with the separation, tools work much more staightforward, withouth the need to call out for make, which in turn makes development using a IDE just that bit simpler. e.g. go test ./... now just works.

This commit also removes the kubernetes feature gates from occm, since they are not in use, and don't make much sense.

Which issue this PR fixes(if applicable): fixes #1861

Special notes for reviewers:

Release note:

NONE

chrigl avatar May 14 '22 15:05 chrigl

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chrigl after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 14 '22 15:05 k8s-ci-robot

/hold /milestone v1.25

Let's first cut release-1.24 !?

chrigl avatar May 14 '22 16:05 chrigl

yes, we should have our 1.24 release first

jichenjc avatar May 16 '22 01:05 jichenjc

/test openstack-cloud-csi-cinder-e2e-test

jichenjc avatar May 16 '22 02:05 jichenjc

/retest

chrigl avatar May 17 '22 11:05 chrigl

@chrigl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 19 '22 12:05 k8s-ci-robot

@chrigl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-controller-manager-e2e-test 815e1ad9a769a82b71d2784cc67fcba995154af4 link true /test openstack-cloud-controller-manager-e2e-test
openstack-cloud-csi-cinder-e2e-test 815e1ad9a769a82b71d2784cc67fcba995154af4 link true /test openstack-cloud-csi-cinder-e2e-test
openstack-cloud-csi-manila-e2e-test 815e1ad9a769a82b71d2784cc67fcba995154af4 link true /test openstack-cloud-csi-manila-e2e-test
openstack-cloud-csi-cinder-sanity-test 815e1ad9a769a82b71d2784cc67fcba995154af4 link true /test openstack-cloud-csi-cinder-sanity-test
openstack-cloud-csi-manila-sanity-test 815e1ad9a769a82b71d2784cc67fcba995154af4 link true /test openstack-cloud-csi-manila-sanity-test
openstack-cloud-keystone-authentication-authorization-test 815e1ad9a769a82b71d2784cc67fcba995154af4 link true /test openstack-cloud-keystone-authentication-authorization-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jun 14 '22 07:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 12 '22 08:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 12 '22 08:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Nov 11 '22 08:11 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 11 '22 08:11 k8s-ci-robot