controller-tools icon indicating copy to clipboard operation
controller-tools copied to clipboard
verified publisher icon kubernetes-sigs

Add support for adding annotations to CRD

Open alculquicondor opened this issue 3 years ago • 6 comments

For kubernetes projects, if we want to use the sig.k8s.io group for CRDs, we need to provide the annotation api-approved.kubernetes.io. Otherwise, apiserver rejects the CRD.

As a result, we have to manually edit the CRDs produced by controller-gen and continuously edit the files every time there is a type update.

Using kustomize is not possible, because the env-test doesn't load them and it could be problematic to do so (it's an additional dependency).

/kind feature

alculquicondor avatar Feb 18 '22 15:02 alculquicondor

This feature is really needed. Any way to help implementing it?

helayoty avatar Mar 14 '22 15:03 helayoty

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 12 '22 15:06 k8s-triage-robot

/remove-lifecycle stale

FillZpp avatar Jun 13 '22 07:06 FillZpp

@alculquicondor Hey Aldo, let me help you :)

/assign

FillZpp avatar Jun 13 '22 09:06 FillZpp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 11 '22 09:09 k8s-triage-robot

/remove-lifecycle stale

FillZpp avatar Sep 13 '22 02:09 FillZpp