kubernetes-sigs
⚠️ [WIP] Extend builder with generic For, Owns and Watches
Creating this to compare implementations and help with examples and discussion on #2214
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Danil-Grigorev Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-controller-runtime-apidiff | ebea1b0491108121d57978e63af9bfec7f4217ed | link | false | /test pull-controller-runtime-apidiff |
| pull-controller-runtime-test | ebea1b0491108121d57978e63af9bfec7f4217ed | link | true | /test pull-controller-runtime-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I think this got superseded by https://github.com/kubernetes-sigs/controller-runtime/pull/2783, feel free to re-open if you think otherwise.
I believe this PR brings some of the bringing changes on top of #2783, but it deserves a separate issue and a rebase on the core for generics which was implemented. Just didn’t have time to pick this one up yet.