docs icon indicating copy to clipboard operation
docs copied to clipboard

[WIP] Docs for external-snapshot-metadata sidecar container

Open PrasadG193 opened this issue 1 year ago • 5 comments

This PR is a placeholder for adding documentation for external-snapshot-metadata sidecar container. This new sidecar container will be added as a part of enhancement https://github.com/kubernetes/enhancements/issues/3314 KEP: https://github.com/kubernetes/enhancements/pull/4082 Git repo: https://github.com/kubernetes-csi/external-snapshot-metadata

PrasadG193 avatar Jun 27 '24 05:06 PrasadG193

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 27 '24 05:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PrasadG193 Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 27 '24 05:06 k8s-ci-robot

Hi @PrasadG193, this PR should target dev-1.31. Please follow the steps here to open a PR against dev-1.31 branch in the k/website repo.

Princesso avatar Jun 27 '24 07:06 Princesso

@Princesso we don't need changes in the website repo for the enhancement.

PrasadG193 avatar Jun 27 '24 07:06 PrasadG193

Hi @PrasadG193 thanks for the update. I have just gotten confirmation from the release lead, that we need to track this as a doc PR. I'll be following up shortly. Thank you!

Princesso avatar Jul 01 '24 07:07 Princesso

Hello @PrasadG193 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

MaryamTavakkoli avatar Jul 08 '24 20:07 MaryamTavakkoli

Hi @PrasadG193, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

Princesso avatar Jul 15 '24 07:07 Princesso

Folks, the feature implementation is not complete yet, so we didn't start on documentation.

PrasadG193 avatar Jul 17 '24 17:07 PrasadG193

Hello @PrasadG193! Thanks for pointing this out. It's true that Docs PR Ready for Review is usually after Code Freeze. However, the Code Freeze deadline has been moved back for the 1.31 release. See the schedule here: https://www.kubernetes.dev/resources/release/

Docs PR Ready for Review deadline remains yesterday July 16th. This is to allow time before Docs Freeze on Tuesday 30th July 2024, after which will require an exception for this feature to ship with 1.31 if docs aren't merged. Docs Freeze remains July 30th since there is other work needed from then leading up to the release. And SIG Docs and a tech lead will need as much of this time before Docs Freeze as possible to review, give feedback, see iterated changes, then ultimately approve and merge these docs among many others.

Can you make some progress on these docs concurrent to your feature so that we can start the review process? This will move the needle towards quality docs for Kubernetes users. We really appreciate it, thanks!

drewhagen avatar Jul 17 '24 21:07 drewhagen

Hello @PrasadG193👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

MaryamTavakkoli avatar Jul 23 '24 21:07 MaryamTavakkoli

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 21 '24 21:10 k8s-triage-robot

Closing this w.r.t https://github.com/kubernetes-csi/docs/pull/605

PrasadG193 avatar Oct 22 '24 09:10 PrasadG193