Add e2e test for strategic merge patch
Add a test sending (e.g. config map) patches through the same API using:
- JSON patch
- Strategic merge patch
make sure the API client is able to set the content type properly according to the request body, and the patches are applied successfully.
ref: https://github.com/kubernetes-client/python/pull/931#discussion_r314435505
I want to give a shot at this. :)
/assign
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/remove-lifecycle stale
Examples of using these patches:
strategic merge patch: https://github.com/kubernetes-client/python/issues/641#issuecomment-429473349 json patch: https://github.com/kubernetes-client/python/issues/641#issuecomment-468291235
We can have one test sending multiple kinds of patch and make sure nothing fails, or two tests doing the same thing but using different kinds of patch.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-contributor-experience at kubernetes/community. /close
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-contributor-experience at kubernetes/community. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/reopen /remove-lifecycle rotten /lifecycle frozen /priority important-soon
@roycaihw: Reopened this issue.
In response to this:
/reopen /remove-lifecycle rotten /lifecycle frozen /priority important-soon
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi everyone!
After reading the issue, the examples and the e2e tests I would like to give it a try.
As far as I understand I have to add a couple of e2e tests patching a config map with the 2 strategies right?
Thanks for your time!
/assign
Sorry for the multiple pull requests, I made a typo naming the branch.