python icon indicating copy to clipboard operation
python copied to clipboard

Add e2e test for strategic merge patch

Open roycaihw opened this issue 6 years ago • 12 comments

Add a test sending (e.g. config map) patches through the same API using:

make sure the API client is able to set the content type properly according to the request body, and the patches are applied successfully.

ref: https://github.com/kubernetes-client/python/pull/931#discussion_r314435505

roycaihw avatar Sep 10 '19 19:09 roycaihw

I want to give a shot at this. :)

/assign

palnabarun avatar Oct 06 '19 20:10 palnabarun

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 04 '20 20:01 fejta-bot

/remove-lifecycle stale

palnabarun avatar Jan 05 '20 04:01 palnabarun

Examples of using these patches:

strategic merge patch: https://github.com/kubernetes-client/python/issues/641#issuecomment-429473349 json patch: https://github.com/kubernetes-client/python/issues/641#issuecomment-468291235

We can have one test sending multiple kinds of patch and make sure nothing fails, or two tests doing the same thing but using different kinds of patch.

roycaihw avatar Mar 12 '20 00:03 roycaihw

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jun 10 '20 01:06 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Jul 10 '20 01:07 fejta-bot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 05 '21 20:01 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot avatar Feb 04 '21 21:02 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

fejta-bot avatar Mar 06 '21 22:03 fejta-bot

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 06 '21 22:03 k8s-ci-robot

/reopen /remove-lifecycle rotten /lifecycle frozen /priority important-soon

roycaihw avatar Mar 09 '21 00:03 roycaihw

@roycaihw: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten /lifecycle frozen /priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 09 '21 00:03 k8s-ci-robot

Hi everyone!

After reading the issue, the examples and the e2e tests I would like to give it a try.

As far as I understand I have to add a couple of e2e tests patching a config map with the 2 strategies right?

Thanks for your time!

/assign

pmareke avatar Sep 26 '22 20:09 pmareke

Sorry for the multiple pull requests, I made a typo naming the branch.

pmareke avatar Sep 27 '22 07:09 pmareke